This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($filter): $orderBy filter with dates when sorting multiple fields #6746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
@SekibOmazic Thanks for the PR. |
…e fields extend compare method to use Date.valueOf() when comparing dates closes angular#6675 remove custom isDate function - angular already has one
|
@lgalfaso done. |
ckknight
pushed a commit
to ckknight/angular.js
that referenced
this pull request
Jul 16, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type:
How to reproduce:
Component(s): misc core
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
Other Comments:
Request Type:
How to reproduce:
Component(s):
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
Other Comments:
extend compare method to use Date.valueOf() when comparing dates
closes #6676