fix(jqLite): make jqLite('<iframe src="someurl">').contents() return iframe document, as in jQuery #6323
Conversation
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
This might fail on IE8 or something because of the way the test is written, I am curious to see if it passes =) |
|
Hmm, it does fail in IE8 and IE9 :( garr |
|
Well my vote is to check this in after support for IE8 is dropped. In the mean time, folks should continue to use jQuery when they need this functionality |
| iframe = jqLite(iframe_); | ||
| function test() { | ||
| var contents = iframe.contents(); | ||
| expect(contents[0]).toBeTruthy(); |
There was a problem hiding this comment.
in general, don't use toBeTruthy() and toBeFalsy() matchers, there are always better more constrained matchers available. in this case maybe using toBeDefined() would be the best.
|
please apply the small changes requested, disable the test on ie8 and merge. thanks! |
…iframe document, as in jQuery This is a very tiny change to make behaviour consistent with jQuery. Closes angular#6320
|
Made the changes, added some extra wait time due to flakiness, and merged. If it needs a revert later on, I won't be mad (passing build: https://travis-ci.org/caitp/angular.js/builds/19149636) |
…iframe document, as in jQuery This is a very tiny change to make behaviour consistent with jQuery. Closes angular#6320 Closes angular#6323
This is a very tiny change to make behaviour consistent with jQuery.
Closes #6320