Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngRoute): pipe preceding route param no longer masks ? or * operator #5920

Closed
wants to merge 1 commit into from

Commits on Jan 21, 2014

  1. fix(ngRoute): pipe preceding route param no longer masks ? or * operator

    Before this change,
    
    ```js
    $routeProvider.when('/foo/:bar|?', { ... });
    ```
    
    would not have the expected effect --- the parameter would not be optional, and
    the pipe would not be included in the parameter name.
    
    Following this change, the presence of the pipe operator will typically cause an
    exception to be thrown due to the fact that the generated regexp is invalid.
    
    The net result of this change is that ? and * operators will not be masked, and
    pipe operators will need to be removed, although it's unexpected that these are
    being used anywhere.
    caitp committed Jan 21, 2014
    Configuration menu
    Copy the full SHA
    6f5fb1e View commit details
    Browse the repository at this point in the history