Update ngEventDirs.js #5852
Update ngEventDirs.js #5852
Conversation
|
The angular docs have a directive for a directive's priority: It might be good to add this for each of the ngEventDirs directives if it's going to be added to ngClick, but I believe if |
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I'll sign the CLA after work today, and add @priority flags to all the ngeventdirs (and squash commits). |
|
You don't need to sign the CLA for docs fixes, despite what @mary-poppins says, but it will prevent the bot from bugging you about it in the future if you do, so go for it |
|
CLA signed electronically. @priority added to all ng event directives |
adding priority to all ng event directives better syntax
I think that the assumption if the @priority is not defined hsould be that the priority is 0, BUT I don't necessarily think that it's harmful to be explicit about this. Closes angular#5852
|
I had a typo when I said Also, it would be good to put the I've amended the commit for you with these changes, but unfortunately the e2e test which makes a request to angularjs.org is failing right now, so I don't totally want to merge it just yet because of that |
|
Merged, thanks |
The general assumption is that if @priority is not defined, the priority is 0. BUT it's not necessarily harmful to be explicit about this. Closes angular#5852
The general assumption is that if @priority is not defined, the priority is 0. BUT it's not necessarily harmful to be explicit about this. Closes angular#5852
Note priority of ng-click in documentation