This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngShow/ngHide, ngIf): functions with zero args should be truthy #5605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, expressions that were a function with one or more arguments evaluated to true, but functions with zero arguments evaluated to false. This behavior seems both unintentional and undesirable. This patch makes a function truthy regardless of its number of arguments. Closes angular#5414
| @@ -20,6 +20,16 @@ describe('ngShow / ngHide', function() { | |||
| })); | |||
|
|
|||
|
|
|||
| // https://github.com/angular/angular.js/issues/5414 | |||
| it('should show if the expression is a function with a single argument', inject(function($rootScope, $compile) { | |||
There was a problem hiding this comment.
what's the significance of "single argument"? I don't see it used in the actual test.
There was a problem hiding this comment.
oops! should be "zero arguments."
ghost
assigned 
|
lgtm |
|
can we get this merged for the release? |
|
yes |
|
Landed as 01c5be4. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, expressions that were a function with one or more arguments evaluated to true, but functions with zero arguments evaluated to false.
This behavior seems both unintentional and undesirable. This patch makes a function truthy regardless of its number of arguments.
Closes #5414