This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($animate): ensure class-based animations are always skipped before structural digests are run #5600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"structural digests" ? did you mean "structural animations" ? |
| if(!ngAnimateState.running || !(isClassBased && ngAnimateState.structural)) { | ||
| var allowAnimations = isClassBased ? | ||
| !ngAnimateState.disabled && (!ngAnimateState.running || !ngAnimateState.structural) : | ||
| true; |
There was a problem hiding this comment.
why true? wouldn't this prevent us from being able to disable animations in e2e tests?
|
we discussed this via chat. @matsko is this ready to be merged? |
…e structural post-digest tasks are run Closes angular#5582
|
MERGED |
|
Landed as bc492c0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5582