This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($location): parse xlink:href for SVGAElements #5472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much |
ghost
assigned 
| anchor.href = url; | ||
| var abs = anchor.href; | ||
| anchor.href = ''; | ||
| return abs; |
There was a problem hiding this comment.
we have a nifty utility for this, check out urlResolve(url).href in urlUtils.js
There was a problem hiding this comment.
I knew there was something somewhere, just couldn't find it! Thanks
|
otherwise this looks good. |
Before this fix, the xlink:href property of an SVG <a> element could not be parsed on click, as the property is an SVGAnimatedString rather than a DOMString. This patch parses the xlink:href's animVal into a DOMString in order to prevent an `Object #<SVGAnimatedString> has no method 'indexOf'` exception from being thrown, and also to update the location if necessary as expected.
This was referenced Dec 19, 2013
|
@caitp thanks! |
|
@caitp next time please list all related issues and PRs in the commit message, I amended your PR to fix this. thanks a bunch for quick turnaround |
|
Sorry about that, I added the ones @Narretz mentioned, but didn't do a search for similar ones. Do you know of a good tool to search for matching issues on github? I've tried using the advanced search feature, but it tends to not find everything |
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
Before this fix, the xlink:href property of an SVG <a> element could not be parsed on click, as the property is an SVGAnimatedString rather than a DOMString. This patch parses the xlink:href's animVal into a DOMString in order to prevent an `Object #<SVGAnimatedString> has no method 'indexOf'` exception from being thrown, and also to update the location if necessary as expected. Closes angular#5472 Closes angular#5198 Closes angular#5199 Closes angular#4098 Closes angular#1420
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
Before this fix, the xlink:href property of an SVG <a> element could not be parsed on click, as the property is an SVGAnimatedString rather than a DOMString. This patch parses the xlink:href's animVal into a DOMString in order to prevent an `Object #<SVGAnimatedString> has no method 'indexOf'` exception from being thrown, and also to update the location if necessary as expected. Closes angular#5472 Closes angular#5198 Closes angular#5199 Closes angular#4098 Closes angular#1420
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the xlink:href property of an SVG
<a>element could not be parsed on click, as the property is an SVGAnimatedString rather than a DOMString.This patch parses the xlink:href's animVal into a DOMString in order to prevent an
Object #<SVGAnimatedString> has no method 'indexOf'exception from being thrown, and also to update the location if necessary as expected.Fixes #5198, #5199, #4098, #1420