Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Do not hold input composition on android #5464

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/ng/directive/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -395,15 +395,17 @@ function textInputType(scope, element, attr, ctrl, $sniffer, $browser) {
// In composition mode, users are still inputing intermediate text buffer,
// hold the listener until composition is done.
// More about composition events: https://developer.mozilla.org/en-US/docs/Web/API/CompositionEvent
var composing = false;
if (!$sniffer.android) {
var composing = false;

element.on('compositionstart', function() {
composing = true;
});
element.on('compositionstart', function(data) {
composing = true;
});

element.on('compositionend', function() {
composing = false;
});
element.on('compositionend', function() {
composing = false;
});
}

var listener = function() {
if (composing) return;
Expand Down
1 change: 1 addition & 0 deletions src/ng/sniffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ function $SnifferProvider() {
vendorPrefix: vendorPrefix,
transitions : transitions,
animations : animations,
android: android,
msie : msie,
msieDocumentMode: documentMode
};
Expand Down
1 change: 1 addition & 0 deletions test/ng/snifferSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ describe('$sniffer', function() {
});
inject(function($sniffer) {
expect($sniffer.transitions).toBe(true);
expect($sniffer.android).toBe(2);
});
});

Expand Down