Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($animate): Correctly retain the old element styles when applyStyle... #4872

Closed
wants to merge 1 commit into from

Conversation

deakster
Copy link

...adds new ones. Fixes #4869

@deakster
Copy link
Author

There's test failures in ngdocSpec, but pretty sure this fix is correct?

@petebacondarwin
Copy link
Member

@deakster - have you signed the CLA?

@petebacondarwin
Copy link
Member

The fix looks good to me but it will need a failing unit test as well (that is fixed by this commit).

@deakster
Copy link
Author

@petebacondarwin Yes, I have signed the CLA yesterday, just before the PR. I added a unit test for the fixed issue.

@ghost ghost assigned matsko Nov 11, 2013
@deakster
Copy link
Author

Travis CI says the build got stalled, can someone trigger a restart?

@petebacondarwin
Copy link
Member

Travis is always a bit flaky. Matias is looking at this and should push to
a branch that will trigger a build on the ci server before merging to
master. If ci is good we are happy
On 11 Nov 2013 11:46, "deakster" [email protected] wrote:

@petebacondarwin https://github.com/petebacondarwin Yes, I have signed
the CLA yesterday, just before the PR. I added a unit test for the fixed
issue.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4872#issuecomment-28192292
.

… also ensure that outdated styles aren't restored on completion. Fixes angular#4869.
@matsko
Copy link
Contributor

matsko commented Nov 22, 2013

Replaced by: #5084

@matsko matsko closed this Nov 22, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngAnimate 1.2 final, inline style and ngStyle are ignored during animations.
3 participants