Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngInclude): only run anchorScroll after animation is done #4758

Closed

Conversation

petebacondarwin
Copy link
Member

We need to wait until animations have added the content to the document before
trying to autoscroll to anchors that may have been inserted.

I am a little unsure about how I refactored the tests to check for this issue.

Also, could someone check whether other things should be moved into the afterAnimation
handler, such as the $compile, the $emit or the $eval?

We need to wait until animations have added the content to the document before
trying to `autoscroll` to anchors that may have been inserted.

Fixes angular#4723
@IgorMinar
Copy link
Contributor

I asked @jeffbcross to take this one over

@ghost ghost assigned jeffbcross Nov 5, 2013
@IgorMinar
Copy link
Contributor

Jeff, please fix the tests to use animate mock and create a new commit that will make the same change to ngView.

@jeffbcross
Copy link
Contributor

I amended Pete's commit with requested changes, and added ngView fix in a separate PR: #4801

@jeffbcross jeffbcross closed this Nov 6, 2013
@petebacondarwin petebacondarwin deleted the ngInclude-anchorScroll branch February 11, 2014 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants