This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngInclude): only run anchorScroll after animation is done #4758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to wait until animations have added the content to the document before
trying to
autoscroll
to anchors that may have been inserted.I am a little unsure about how I refactored the tests to check for this issue.
Also, could someone check whether other things should be moved into the
afterAnimation
handler, such as the
$compile
, the$emit
or the$eval
?