feat($sce): simpler patterns for $sceDelegateProviders white/blacklists #4148

chirayuk · 2013-09-25T02:04:14Z

mary-poppins · 2013-09-25T02:04:16Z

Thank you, Chirayu! You rock!

IgorMinar · 2013-09-26T00:43:25Z

docs/content/error/sce/badwcard.ngdoc

@@ -0,0 +1,9 @@
+@ngdoc error
+@name $sce:badwcard
+@fullName The sequence *** is not valid the string pattern


"the string pattern"?

is not a valid pattern wildcard

Done. chirayuk@f93ca0e#diff-23117a3a20f83a4f6ef2d57221497ab9R3

IgorMinar · 2013-09-26T14:55:39Z

some minor changes requested, but overall this looks great. thanks!

IgorMinar · 2013-09-26T15:05:53Z

if you don't contest any changes, please make them and merge the PR

chirayuk · 2013-10-01T02:46:12Z

@IgorMinar – I've addressed your comments. The not-done items are:–

Using <pre> gives me syntax coloring. Github style doesn't. :( So I'm still using <pre> for the examples.
The msie > 8 check is still there. See comment just above it. I haven't been able to fix it.

I might go ahead and merge this in if the CI server comes back happy.

ghost assigned IgorMinar Sep 25, 2013

IgorMinar reviewed Sep 26, 2013
View reviewed changes

feat($sce): simpler patterns for $sceDelegateProviders white/blacklists

93ce592

Closes angular#4006

chirayuk merged commit 93ce592 into angular:master Oct 1, 2013

Provide feedback