Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(core): parse IE11 UA string correctly #3758

Closed
wants to merge 0 commits into from

Conversation

chirayuk
Copy link
Contributor

Ref: http://msdn.microsoft.com/en-us/library/ms537503.aspx

It's great that IE11 wants to be compatible enough that it doesn't want
to be special cased and treated differently.

However, as long as one has to have a different code path for IE than
for the other supported browsers, we still need to detect and special
case it. For instance, our URL parsing code still needs the same
workaround the we used for IE10. We still see the same Access denied /
TypeError exceptions when setting certain values. FYI, Angular doesn't
generally blindly test for IE – we also check the version number.

Thanks to modern.ie for the free IE11 test VM.

Closes #3682

@vojtajina
Copy link
Contributor

We can run it on BrowserStack, they have IE11.

@vojtajina
Copy link
Contributor

I run it on browserstack and it seems to be passing:

$ karma start karma-jquery.conf.js --browsers BS_IE_11
INFO [karma]: Karma v0.10.2 server started at http://localhost:9876/
INFO [launcher]: Starting browser ie 11.0 (Windows 7) on BrowserStack
INFO [IE 11.0.0 (Windows 7)]: Connected on socket r5nwq4hwjI74BKw76xn2
IE 11.0.0 (Windows 7): Executed 2217 of 2217 SUCCESS (33.272 secs / 21.16 secs)

@chirayuk
Copy link
Contributor Author

It passes in the Windows VM I got from modern.ie.  I just updated this PR to extract the version from parse the rv:11.x like I did in an earlier commit instead of parsing the Trident version + 4.  While the Trident version has been present for a few releases and seems the way to go, it basically marks the rendering engine version and doesn't talk about the browser as a whole (e.g. JS) I think. Though rv has been introduced recently, my inclination is that it's going to track the evergreen tip the way Chrome tracks theirs.  I might add a test to our suite to fail if these two don't match – so we can detect when they differ and re-visit this issue. Until then, it's going to be the rv version.

@chirayuk
Copy link
Contributor Author

Added the check as mentioned in the previous comment,

@chirayuk
Copy link
Contributor Author

Landed as 427ee93

@chirayuk chirayuk closed this Aug 29, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocked loading resource from url not allowed. IE11
2 participants