This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Under certain circumstances location.href is not defined in IE8. #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h sometimes causes an infinite routing loop
|
Thanks for the patch. Do you know how to reproduce this error? The fix looks a bit odd. Attaching a test case would make it easier to understand what's going on. |
|
We have an application that reliably fails in IE8 (and emulated modes for IE8). I'll try to isolate it into a smaller reproduce-able chunk. I'll write a plunk and attach it here later. |
PR Checklist (Minor Bugfix)
|
|
@vsviridov - can you also sign the CLA and look at our commit message guidelines? Thanks. |
|
I've signed the CLA. Couldn't really isolate it, but here's a version that partially breaks in IE8 |
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this pull request
Jul 24, 2013
If an app uses HTML5 mode and we open an html5 url on IE8 or 9 which don't support location href, we use location.replace to reload the page with the hashbang equivalent of the url but this fails with infinite digest. This is because location.replace doesn't update location.href synchronously on IE8 and 9. Closes angular#2802, angular#3305, angular#1417
IgorMinar
pushed a commit
that referenced
this pull request
Jul 24, 2013
If an app uses HTML5 mode and we open an html5 url on IE8 or 9 which don't support location href, we use location.replace to reload the page with the hashbang equivalent of the url but this fails with infinite digest. This is because location.replace doesn't update location.href synchronously on IE8 and 9. Closes #2802, #3305, #1417
IgorMinar
pushed a commit
that referenced
this pull request
Jul 24, 2013
If an app uses HTML5 mode and we open an html5 url on IE8 or 9 which don't support location href, we use location.replace to reload the page with the hashbang equivalent of the url but this fails with infinite digest. This is because location.replace doesn't update location.href synchronously on IE8 and 9. Closes #2802, #3305, #1417
|
fixed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sometimes causes an infinite routing loop.