This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
jqLlite fixes #319
Merged
jqLlite fixes #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
our original implementation doesn't work with document fragments on IE - tests were added to cover missing cases
this is needed to be compatible with jqQuery 1.5.1
tests cover: - creating comment tags from a string - creating script tag from a string - wrapping document fragment
can we agree to put more white space into our code? I follow there rules for specs: - 1 blank line between sections of nontrivial it block - 2 blank lines between it blocks - 2 blank lines between describe blocks - 2 blank lines between beforeEach and afterEach - no blank line between describe and the first child it - no blank lines between two or more closing }); lines
|
btw all tests now pass: http://build.hevery.com/job/angular.js-igorminar-presubmit/9/console |
|
LGTM |
|
angular.js: master commits 15ec78f...eccd9bf - http://bit.ly/fYHZQ5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bunch of fixes needed for IE and jQuery compatibility