Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Fix for"10 $digest() iterations reached" with IE9 and IE8 #2782

Merged
merged 0 commits into from
Jul 18, 2013

Conversation

pvasek
Copy link
Contributor

@pvasek pvasek commented May 24, 2013

There was an issue with location.replace method isn't changing the location.href immediately.

@scottux
Copy link

scottux commented Jul 8, 2013

This fixed the "10 $digest() iterations reached" for me.

@petebacondarwin
Copy link
Contributor

PR Checklist (Minor Bugfix)

  • Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name)
  • PR doesn't introduce new api
  • PR doesn't contain a breaking change
  • PR contains unit tests
  • PR contains e2e tests (if suitable)
  • PR contains documentation update (if suitable)
  • PR passes all tests on Travis (sanity)
  • PR passes all tests on ci.angularjs.org (cross-browser compatibility)
  • PR is rebased against recent master
  • PR is squashed into one commit per logical change
  • PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
  • All changes requested in review have been implemented

@petebacondarwin
Copy link
Contributor

@pvasek - thanks for this PR.
Can you take a look at the outstanding tasks? In particular we will need you to sign the CLA. We will need some unit tests to demonstrate the bug to ensure that the bug cannot return in the future.
Also, can you take a look at our commit message guidelines and reword your commit when you update this pull request with tests?

@pvasek
Copy link
Contributor Author

pvasek commented Jul 17, 2013

@petebacondarwin: CLA signed Pavel Vasek. I will look to the unit tests in the moment

@pkozlowski-opensource pkozlowski-opensource merged commit 1a8d83d into angular:master Jul 18, 2013
@IgorMinar
Copy link
Contributor

I think this PR got closed by accident or github bug.

I think the PR referred to e8f9dd7

@IgorMinar
Copy link
Contributor

Can you please open a new PR with this fix and add a test? Thanks!

@pvasek
Copy link
Contributor Author

pvasek commented Jul 19, 2013

That is not a problem. This is a duplicate of this one #2802 which was created from the correct local branch. I will try to do that there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants