Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($compile): rename $compileNote to compileNode #1950

Closed
wants to merge 1 commit into from
Closed

fix($compile): rename $compileNote to compileNode #1950

wants to merge 1 commit into from

Conversation

iknite
Copy link

@iknite iknite commented Feb 4, 2013

Directives was observing different instances of Attributes than the one that interpolation was registered with.

Closes #1941

@IgorMinar
Copy link
Contributor

PR Checklist (Minor Bugfix)

  • Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name)
  • PR doesn't introduce new api
  • PR doesn't contain a breaking change
  • PR contains unit tests
  • PR contains e2e tests (if suitable)
  • PR contains documentation update (if suitable)
  • PR passes all tests on Travis (sanity)
  • PR passes all tests on ci.angularjs.org (cross-browser compatibility)
  • PR is rebased against recent master
  • PR is squashed into one commit per logical change
  • PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
  • All changes requested in review have been implemented

@ghost ghost assigned IgorMinar Feb 4, 2013
@IgorMinar
Copy link
Contributor

@iknite can you squash this into a single commit (git rebase -i HEAD~4) and update the commit message please

Directives was observing different instances of Attributes than the one
that interpolation was registered with.

Closes #1941
@iknite
Copy link
Author

iknite commented Feb 5, 2013

Thanks for the guidance 🍻

@IgorMinar
Copy link
Contributor

landed as 92ca7ef

thanks!

if you haven't received our t-shirt before and would like one, please fill out this form: http://goo.gl/075Sj

@IgorMinar IgorMinar closed this Feb 7, 2013
@iknite
Copy link
Author

iknite commented Feb 7, 2013

Thanks guys!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

templateURL in directive breaks interpolation in $observe
2 participants