Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feat(limitTo): limitTo filter accepts strings #1653

Closed
wants to merge 1 commit into from
Closed

feat(limitTo): limitTo filter accepts strings #1653

wants to merge 1 commit into from

Conversation

jtymes
Copy link
Contributor

@jtymes jtymes commented Dec 5, 2012

This allows strings to be filtered by limitTo, using the same methods

Closes #653

@IgorMinar
Copy link
Contributor

LGTM otherwise. can you please fix the issues and push update to this branch?

@jtymes
Copy link
Contributor Author

jtymes commented Dec 13, 2012

@IgorMinar Should be good now.

@pkozlowski-opensource
Copy link
Member

@jtymes Just pushed it to a test branch and getting tests failures on IE8:

IE 8.0 (Windows) Filter: limitTo should return the last X items when X is negative FAILED
    Expected 'tuvwxyz' to equal 'xyz'.
    Expected 'tuvwxyz' to equal 'xyz'

I guess that the reason is this one: http://stackoverflow.com/a/6918982/1418796
Could you try to change it to make IE8 happy and re-submit? Thnx!

@jtymes
Copy link
Contributor Author

jtymes commented Dec 19, 2012

@pkozlowski-opensource Darn you windows people ;) I'll fix it up!

This allows strings to be filtered by limitTo, using the same methods

Closes #653
@pkozlowski-opensource
Copy link
Member

Landed as 9e96d98. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limitTo filter should accept strings as well
3 participants