fix(*): remove text-shadow from prettify theme #16496
Conversation
Previously, the styling on the AngularJS bits (tags, attributes, placeholders) in the code examples include a white colored text-shadow on a light blue background. This makes text difficult to read. This commit removes this shadow to improve readability. closes #16495
|
Is this the right place to fix it? I thought the site was built off of https://github.com/angular/angularjs.org (in which case this is the style you would need to override). |
|
That's right, Angularjs.org is not built from this here repository. |
|
Oh that's confusing, the css file looks very alike. But I guess that's why I asked you (@gkalpak) how to be able to verify this change locally (I made the PR as I was pretty sure I had the right file, but still needed local verification). What's the css file in this repo used for then 😕 ? (it's probably just a left over from the migration ? ) Anyway, If you don't mind I can still move this change to that repo. But it might be a good idea to address this #16495 (comment) |
|
The |
|
@gkalpak Does the changes in this repo makes sense in that case? To align both of them ? But I guess the implementation in this PR is incorrect as it modified the original CSS file and I'm guessing we want it to be overridden instead of modified inside that file ? |
|
I don't think we use light-blue, highlighted regions here. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Styling improvement
What is the current behavior? (You can also link to an open issue here)
The styling on the AngularJS bits (tags, attributes, placeholders) in the code examples include a white colored text-shadow on a light blue background. This makes text difficult to read.
What is the new behavior (if this is a feature change)?
This commit removes this shadow to improve readability.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
#16495