This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(Scope): ensure that a scope is destroyed only once #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to bd524fc calling $destroy() on a scope mupltiple times cases NPE. Closes angular#1627
|
LGTM This Plunkr has this commits changes and the issue in #1627 does occur now: http://plnkr.co/edit/IOeW5Q?p=preview |
|
does occur? |
|
looks good on plunker |
|
landed this as d6da505 |
|
Sorry "doesn't" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to bd524fc calling $destroy() on a scope mupltiple times cases NPE.
Closes #1627