Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix for issue #1553 #1629

Closed
wants to merge 2 commits into from
Closed

fix for issue #1553 #1629

wants to merge 2 commits into from

Conversation

lanterndev
Copy link
Contributor

@lanterndev lanterndev commented Nov 29, 2012

Fixes #1553. Includes a test demonstrating the issue.

@petebacondarwin
Copy link
Member

Hi @Skivvies - LGTM. I assume you have signed the CLA?

@lanterndev
Copy link
Contributor Author

Thanks @petebacondarwin, glad to hear it. Re the CLA, how does that work if I'd like to remain anonymous?

@lanterndev
Copy link
Contributor Author

When a commit is 1) trivial and unoriginal, and 2) made by an anonymous contributor, would that contributor even have any legal claim to the IP, assuming she later decided to reveal her identity and try to prove she was the original anonymous contributor? Maybe this doesn't have to stall if the CLA isn't necessary anyway.

@petebacondarwin
Copy link
Member

How anonymous do you want to be? Perhaps you could sign the CLA, which is not a public document and then privately email Igor and let him know that you are signed up?
I doubt that they can accept without CLA.

@lanterndev
Copy link
Contributor Author

@petebacondarwin Okay, signed the CLA and just emailed @IgorMinar.

@petebacondarwin
Copy link
Member

Great!

On 30 November 2012 23:54, skivvies [email protected] wrote:

@petebacondarwin https://github.com/petebacondarwin Okay, signed the
CLA and just emailed @IgorMinar https://github.com/IgorMinar.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1629#issuecomment-10908994.

@IgorMinar
Copy link
Contributor

@Skivvies awesome work! thanks for splitting the PR into two commits. I didn't get any email from you regarding CLA, but I was able to make track you down based on github timestamps.

fyi: if you used the same email address for git and CLA the connection would be much more obvious ;-)

@IgorMinar
Copy link
Contributor

landed as 26adeb1

thanks! would you like a t-shirt if you don't have one already? http://goo.gl/075Sj

@IgorMinar IgorMinar closed this Dec 5, 2012
@lanterndev
Copy link
Contributor Author

Thanks @IgorMinar! I emailed the address associated with your commits in the git log, [email protected]. Should I have used another?

Thanks for the quick turnaround on this one, and for the awesome work on Angular in general. Look forward to contributing more in the future!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binding in select with multiple using optgroups fails
3 participants