This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(copy): support copying MediaStream object #16061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-amr
force-pushed
the
support_copy_mediastreem
branch
3 times, most recently
from
a13e362 to
dd53058
Compare
use MediaStream clone method to clone mediastream object Closes angular#16055
gkalpak
suggested changes
Jul 3, 2017
There was a problem hiding this comment.
Besides the failing tests, I don't think this is a good idea. See #16055 (comment).
| @@ -603,6 +603,18 @@ describe('angular', function() { | |||
| /* eslint-enable */ | |||
| }); | |||
|
|
|||
| it('should copy media stream objects', function() { | |||
| var source = new MediaStream(); | |||
There was a problem hiding this comment.
Not all browsers support MediaStream (which seems to cause Travis to fail).
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Jan 14, 2019
Closes angular#5085 Closes angular#13193 Closes angular#14352 Closes angular#15904 Closes angular#16055 Closes angular#16061 Closes angular#16067
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Jan 14, 2019
Closes angular#5085 Closes angular#13193 Closes angular#14352 Closes angular#15904 Closes angular#16055 Closes angular#16061 Closes angular#16067
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Jan 14, 2019
Closes angular#5085 Closes angular#13193 Closes angular#14352 Closes angular#15904 Closes angular#16055 Closes angular#16061 Closes angular#16067
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Jan 21, 2019
Closes angular#5085 Closes angular#13193 Closes angular#14352 Closes angular#15904 Closes angular#16055 Closes angular#16061 Closes angular#16067
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use MediaStream clone method to clone mediastream object
Closes #16055
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug, fix Issue #16055
What is the current behavior? (You can also link to an open issue here)
angular.copy does not work with (Local)MediaStream objects. This affects the watchability of objects that contain such an object.
What is the new behavior (if this is a feature change)?
copy MediaStream object using
MediaStream.clone()based on documentationhttps://developer.mozilla.org/en-US/docs/Web/API/MediaStream/clone
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: