This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(docsApp): show correct version number in api index #15265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the index would show the version of Angular that runs on the page, not the version for which the docs are. This meant that in that snapshot docs the stable version was displayed. The `$scope.docsVersion` value was used in the plnkr opening code, but has not been used since angular@bdec35c.
| @@ -8,8 +8,6 @@ angular.module('DocsController', []) | |||
| function($scope, $rootScope, $location, $window, $cookies, | |||
| NG_PAGES, NG_NAVIGATION, NG_VERSION) { | |||
|
|
|||
| $scope.docsVersion = NG_VERSION.isSnapshot ? 'snapshot' : NG_VERSION.version; | |||
There was a problem hiding this comment.
I think that you removed this because it is not actually used anywhere?
There was a problem hiding this comment.
Yes, that is correct. (this is docsVersion, below is just version)
| $scope.versionNumber = angular.version.full; | ||
| $scope.version = angular.version.full + ' ' + angular.version.codeName; | ||
| $scope.versionNumber = NG_VERSION.full; | ||
| $scope.version = NG_VERSION.full + ' ' + NG_VERSION.codeName; |
There was a problem hiding this comment.
In the master build, I don't think that there is a codeName etc...
Don't we need to do some logic similar to what was removed in line 11 above?
There was a problem hiding this comment.
The codename for the snapshot is actually "snapshot", at least when built locally.
|
OK, let's go with this. |
Narretz
added a commit
that referenced
this pull request
Nov 4, 2016
Previously, the index would show the version of Angular that runs on the page, not the version for which the docs are. This meant that in that snapshot docs the stable version was displayed. The `$scope.docsVersion` value was used in the plnkr opening code, but has not been used since bdec35c. Closes #15265
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Previously, the index would show the version of Angular that runs on the page, not the version for which the docs are. This meant that in that snapshot docs the stable version was displayed. The `$scope.docsVersion` value was used in the plnkr opening code, but has not been used since angular@bdec35c. Closes angular#15265
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Previously, the index would show the version of Angular that runs on the page, not the version for which the docs are. This meant that in that snapshot docs the stable version was displayed. The `$scope.docsVersion` value was used in the plnkr opening code, but has not been used since angular@bdec35c. Closes angular#15265
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Previously, the index would show the version of Angular that runs on the page, not the version for which the docs are. This meant that in that snapshot docs the stable version was displayed. The `$scope.docsVersion` value was used in the plnkr opening code, but has not been used since angular@bdec35c. Closes angular#15265
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Previously, the index would show the version of Angular that runs on the page, not the version for which the docs are. This meant that in that snapshot docs the stable version was displayed. The `$scope.docsVersion` value was used in the plnkr opening code, but has not been used since angular@bdec35c. Closes angular#15265
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
Previously, the index would show the version of Angular that runs on the page, not the version for which the docs are. This meant that in that snapshot docs the stable version was displayed. The `$scope.docsVersion` value was used in the plnkr opening code, but has not been used since angular@bdec35c. Closes angular#15265
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 23, 2016
Previously, the index would show the version of Angular that runs on the page, not the version for which the docs are. This meant that in that snapshot docs the stable version was displayed. The `$scope.docsVersion` value was used in the plnkr opening code, but has not been used since bdec35c. Closes #15265
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 24, 2016
Previously, the index would show the version of Angular that runs on the page, not the version for which the docs are. This meant that in that snapshot docs the stable version was displayed. The `$scope.docsVersion` value was used in the plnkr opening code, but has not been used since bdec35c. Closes #15265
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Previously, the index would show the version of Angular that runs on the page, not the version for which the docs are. This meant that in that snapshot docs the stable version was displayed. The `$scope.docsVersion` value was used in the plnkr opening code, but has not been used since angular@bdec35c. Closes angular#15265
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix in the docs app
What is the current behavior? (You can also link to an open issue here)
On https://docs.angularjs.org/api, the text currently says
but the default docs are for the master / snapshot version.
Please check if the PR fulfills these requirements
Other information:
Previously, the index would show the version of Angular that runs on
the page, not the version for which the docs are. This meant that in
that snapshot docs the stable version was displayed.
The
$scope.docsVersionvalue was used in the plnkr opening code, buthas not been used since bdec35c.