feat(ngView): reference resolved locals in scope

[shahata]

this will make it easier to use ng-route with component pattern by being able to configure something like $routeProvider.when('/', {resolve: {items: ($http) => $http.get(...)}, template: '<my-app items="resolve.items" />'}); and not having to configure a dummy controller that puts the resolved values on the scope.

[shahata]

In a nutshell I tried to write a new application with using only module.component and avoiding standalone controllers and ended up writing something like:

$routeProvider.when('/', {
  template: '<my-app items="resolve.items" />',
  resolve: {items: ($http) => $http.get(…)},
  controllerAs: 'resolve',
  controller: function (items) { this.items = items; }
});

It is pretty ugly that I need to define the controller only so I can get the resolve results in the template...
With this PR I can do this instead:

$routeProvider.when('/', {
  template: '<my-app items="resolve.items" />',
  resolve: {items: ($http) => $http.get(…)}
});

[gkalpak]

The test description is kibd of undescriptive (I wouldn't have guessed what's supposed to do just by reading the description).

[petebacondarwin]

How about a resolvesAs property to be consistent with controllerAs when attaching things to the scope?
Then module.component could default to $resolves...

[shahata]

@petebacondarwin sure, that makes sense. I'll update the PR. Do you prefer resolvesAs over resolveAs? For me the second sounds better, but maybe that's my broken English :)

[petebacondarwin]

Right, so the property that we are aliasing is resolve right? So the property that specifies what this alias should be called is resolveAs.
You're right.

[shahata]

Added resolveAs. @petebacondarwin do you think we should consider this change for 1.5? Using angular-route with components is very strange otherwise...

[shahata]

oh, I read your original comment again. You mean that this functionality will work only if the route has resolveAs and that module.component will pass resolveAs: '$resolve'? I'm not sure that this is possible since resolveAs is a property of the route, not of the component...

[petebacondarwin]

I didn't realise that this had nothing to do with module.component.

How about:

$routeProvider.when('/', {
  template: '<my-app items="myResolve.items" />',
  resolve: {items: ($http) => $http.get(…)}
  controllerAs: 'myResolve'
});

Then that would mean that a default controller is created that contains all the resolves as properties.
This would not work if a controller was actually specified. In otherwords:

$routeProvider.when('/', {
  template: '<my-app items="$resolve.items" />',
  resolve: {items: ($http) => $http.get(…)}
  controllerAs: '$resolve',
  controller: function() { ... }
});

In this second case the resolves would not be bound to the specified controller.

Then the most simple case is that neither controller nor controllerAs are provided, in which case controllerAs defaults to $resolve and the controller defaults to one that contains the resolves:

$routeProvider.when('/', {
  template: '<my-app items="$resolve.items" />',
  resolve: {items: ($http) => $http.get(…)}
});

[petebacondarwin]

Actually looking at the actual code of the PR - I think that this is good as it is. Let's merge!

[gkalpak]

There should be docs for this feature right ?

[petebacondarwin]

Agh! Good point @gkalpak