Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

remove unnecessary return of 'refresh' #13257

Closed
wants to merge 1 commit into from

Conversation

dkrugman
Copy link
Contributor

@dkrugman dkrugman commented Nov 5, 2015

It is not necessary to return a value for refresh in this example.

It is not necessary to return a value for refresh in this example.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@dkrugman
Copy link
Contributor Author

dkrugman commented Nov 5, 2015

  1. I signed it!
  2. The build failure looks like a problem with an unrelated protractor:travis task.

Running "protractor:travis" (protractor) task
........
[safari 7 OS X 10.9 #3] Failures:
[safari 7 OS X 10.9 #3]
[safari 7 OS X 10.9 #3] 1) Customizing the jqlite / jquery version should be able to force jqlite
[safari 7 OS X 10.9 #3] at 0.376s [Thu, 05 Nov 2015 14:18:16 GMT]
[safari 7 OS X 10.9 #3] Message:
[safari 7 OS X 10.9 #3] NoSuchWindowError: The driver is not focused on a window. You must switch to a window before proceeding. (WARNING: The server did not provide any stacktrace information)

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 5, 2015
@gkalpak
Copy link
Member

gkalpak commented Nov 5, 2015

Tests pass now 😃

@gkalpak gkalpak self-assigned this Nov 6, 2015
@gkalpak gkalpak closed this in 92bdd76 Nov 6, 2015
gkalpak pushed a commit that referenced this pull request Nov 6, 2015
@gkalpak
Copy link
Member

gkalpak commented Nov 6, 2015

Baclported to v1.4.x as b0c19f8.

gkalpak pushed a commit to gkalpak/angular.js that referenced this pull request Nov 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants