Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngClassOdd/Even): proper update with filtering/ordering #1264

Closed
wants to merge 2 commits into from

Conversation

petrovalex
Copy link
Contributor

Related to the issue #1076

@mhevery
Copy link
Contributor

mhevery commented Aug 28, 2012

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement).

CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form):
http://code.google.com/legal/individual-cla-v1.0.html

For corporations (print, sign and scan+email, fax or mail):
http://code.google.com/legal/corporate-cla-v1.0.html

@petrovalex
Copy link
Contributor Author

hi, I has already signed it

@ghost ghost assigned mhevery Sep 4, 2012
@mhevery
Copy link
Contributor

mhevery commented Sep 4, 2012

MERGED

@mhevery mhevery closed this Sep 4, 2012
@IgorMinar
Copy link
Contributor

this was not merged properly. Misko stripped the code change and only accepted the tests because supposedly fix for #933 fixed this issue as well. That was a BS and I'm actually considering reverting the fix for #933 so I'm going to reopen this issue as well.

@IgorMinar IgorMinar reopened this Nov 20, 2012
@ghost ghost assigned IgorMinar Nov 20, 2012
@pkozlowski-opensource
Copy link
Member

@petrovalex It was finally fixed by #1602
But thank you very much for this PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants