Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Add hasBody to ngResource action configuration #12180

Closed
wants to merge 1 commit into from

Conversation

yathos
Copy link

@yathos yathos commented Jun 21, 2015

The use of hasBody would allow developers of REST interfaces to decide if a request body is necessary or not on a per method basis.

The way ngResource currently handles request bodies in custom requests make the definition of custom requests pretty useless. It’s not possible to transfere a request body through a other requests than POST, PUT, PATCH. Or am I wrong?

It may be true that some browser implementations are also brocken when it comes to methods like DELETE but this broken behavior should not be enforced by angular.

Even as i read #3207 after creating the patch its somehow picking up pmariduenas comment on creating a enableDeleteRequestBody. Its just the generic version for all custom requests.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@kaufholdr
Copy link
Contributor

I confirm that I am fine with the contribution of this patch to Google.

@yathos
Copy link
Author

yathos commented Jun 21, 2015

Can someone please tell me what to do to get the cia:yes tag?

@caitp
Copy link
Contributor

caitp commented Jun 21, 2015

@yathos the CLA bot doesn't like it when someone elses commits are in your PR --- Perhaps @kaufholdr could submit the PR themselves instead?

@yathos
Copy link
Author

yathos commented Jun 21, 2015

Thank you. Will try it with the correct approach. :-)

@yathos yathos closed this Jun 21, 2015
@yathos
Copy link
Author

yathos commented Jun 21, 2015

The corrected pull request is: #12181

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants