fix($http): promise chain for helper methods

[PatrickJS]

can has less promise chain breaking

angular.module('app', [])
.factory('Auth', function($http) {
  return {
    login: function(data) {
      return $http.post('/signup', data)
        .success(function(data) {
          return data;
        })
        .error(function(err) {
          return $q.reject(err);
        });
    } // end login
  }; // end module
}) // end factory
.controller('MainCtrl', function($scope, $state, Auth) {

  $scope.login = function(user) {
    Auth.login(user).then(function(data) {
      $state.go('dashboard');
    })
    .catch(function(err) {
      alert(err);
    });
  }; // end login
}); // end ctrl

since the promise chain is broken when using Auth.login().then(otherStuff).catch(errorStuff) you get the result from the http and not the error from .error.

[gkalpak]

Based on the discussion at #10508 (especially #10508 (comment)), it seems like success() and error() are heading for deprecation.

Note that fixing their "brokenness" would be quite of a breaking change.

[pkozlowski-opensource]

I'm not big fan of this change - for a start it breaks the existing tests, so this would have to be looked into. Besides it tries to pretend that success and error are promises (or promise-like) while those are ordinary callbacks.

I think that the current situation - although broken - is easier to explain: then is for promises while error / success calbacks are ... plain old callbacks that can be used by people who don't want mess with promises.

My best advice - let go of error / success....

[Narretz]

I agree with @pkozlowski-opensource . Let's not shoehorn promise behavior onto callbacks.

[pkozlowski-opensource]

Yeh, thnx for the suggestion @gdi2290 but we are going to pass on this one...