fix(htmlAnchorDirective): remove event listener if target is not element #10849
Conversation
Previously, when an `a` tag element used a directive with a replacing template, and did not include an `href` or `name` attribute before linkage, the anchor directive would always prevent default. Now, the anchor directive will cancel its event listener if the linked element is not the same as the target element of the event. Closes angular#4262
|
self-reviewed, minimal perf impact, doesn't seem to introduce any new issues |
…e event if target is different element Previously, when an `a` tag element used a directive with a replacing template, and did not include an `href` or `name` attribute before linkage, the anchor directive would always prevent default. Now, the anchor directive will not register an event listener at all if the original directive is replaced with a non-anchor, and will ignore events which do not target the linked element. Closes #4262 Closes #10849
|
This causes regression: previously |
|
please produce a reproduction |
|
Can't include all my project code, but here is link example. <div class="actions">
<a href="" class="remover" ng-click="removeAttachment(attachment)"><span class="glyphicon glyphicon-remove"></span></a>
</div>$scope.removeAttachment = (attachment) ->
log 'remove called'
index = $scope.attachments.indexOf(attachment)
link = $scope.attachments[index]
$scope.attachments.splice index, 1
link.canceler.resolve "aborted"
$http.get(Data.storage.delete + link.id);
link = null
log 'remove completed'
return false |
|
so your issue is that the target element of the click is not the link itself, it's the span/icon. i'll try to produce a fix for that. |
| // SVGAElement does not use the href attribute, but rather the 'xlinkHref' attribute. | ||
| var href = toString.call(element.prop('href')) === '[object SVGAnimatedString]' ? | ||
| 'xlink:href' : 'href'; | ||
| element.on('click', function(event) { | ||
| // If a different element was clicked, ignore it. | ||
| if (element[0] !== event.target) return; |
There was a problem hiding this comment.
I think this line caused regression. preventDefault() is below and not called anymore.
There was a problem hiding this comment.
this code hasn't been released yet, but thanks for testing out the cutting edge, i'll push a fix tonight
There was a problem hiding this comment.
but just to make sure, you aren't using "cutting edge" in production right? that would be a bad idea.
There was a problem hiding this comment.
You are right, I'm not using edge. Just tested my PR
#7995 to be working after rebase.
2015-01-26 14:37 GMT+10:00 ⭐caitp⭐ [email protected]:
In src/ng/directive/a.js
#10849 (comment):// SVGAElement does not use the href attribute, but rather the 'xlinkHref' attribute. var href = toString.call(element.prop('href')) === '[object SVGAnimatedString]' ? 'xlink:href' : 'href'; element.on('click', function(event) {
// If a different element was clicked, ignore it.if (element[0] !== event.target) return;but just to make sure, you aren't using "cutting edge" in production
right? that would be a bad idea.—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular.js/pull/10849/files#r23512554.
Пашин Анатолий,
эникейщик.
Previously, when an
atag element used a directive with a replacing template, and did not include anhrefornameattribute before linkage, the anchor directive would always prevent default.Now, the anchor directive will cancel its event listener if the linked element is not the same as the target element of the event.
Closes #4262