More powerful $cookies service

[reichart]

I want to set a cookie on the root path / so it's available everywhere on the domain.

But the $cookies service only accepts name and value, and always sets the cookie path to the current page via self.baseHref().

Could the $cookies service be extended to provide access to additional cookie properties like path, expires, domain and secure?

I quite like the API of the jquery.cookie plugin: https://github.com/carhartl/jquery-cookie#usage. It keeps the common name=value use case simple and allows to set additional cookie properties via a third options object parameter.

I'm not very proficient in Javascript but I might try to implement something over the weekend.

[jzacsh]

Working on this (first version, I'm not worried about providing jquery's "raw" option), just updating tests now.

branch is here: jzacsh/angular.js@master...issue950_cookies

[jzacsh]

Hey, sorry I forgot to update this thread. Switched teams and don't have the time do this. Someone should take this on :-)

[eddiemonge]

any updates on this?

[solidspark]

+1 for updates and a resolution

[wkonkel]

+1 Not supporting secure cookies is a security issue and should be addressed ASAP.

[rappo]

Just added a $200 bounty to this issue: https://www.bountysource.com/issues/68135-more-powerful-cookies-service

+1

[eddiemonge]

you could always use a different library like: https://github.com/grevory/angular-local-storage

[lewisgoddard]

Would it not be possible to simply replace the existing code for cookie control with a third-party library like jQuery Cookie https://github.com/carhartl/jquery-cookie

This plugin provides support for custom expiry dates, domain names (set example.com from sub.example.com etc), path values, and secure cookies, thus:

$.cookie('cookiename', 'cookievalue', { expires: 7, path: '/', domain: 'example.com', secure: true });

[wkonkel]

Although local-storage and jQuery both provide workarounds, this ticket is for fixing the core issue within AngularJS so workarounds aren't necessary.

[eddiemonge]

angular-cookies is no longer 'core'. its more of a Angular team supported plugin now.

[Narretz]

+1

[bwdolphin]

+1 - for reference this seems to work pretty well - https://github.com/ivpusic/angular-cookie - but I still think this should be part of the included Angular cookie plugin.

[johannesjo]

+1

[jonrimmer]

+1
We were just bitten by this, with cookies being shared between different environments running on the same host but different ports.

The current implementation is dangerous IMO, as it makes it impossible to properly secure cookies you create. This is going to lead to Angular apps which are vulnerable to XSS attacks.

[lucianenache]

+1
what is the current status?

[kbanman]

+1
I'd like to be able to set path, expiry and domain

[HNygard]

👍

[bfowle]

+1

[Jazzepi]

+9001

[marcmenges]

+1

[taly]

+1

[ghost]

+1

[takashi]

👍

[sjogreen-sp]

+1

[JordanRClark]

Plus one

[corkupine]

+1

[grantgeorge]

👍

[dallasvogels]

👍

[PatrickJS]

👍

[Ppchiu]

Is this one still up for grabs by the community? I would love to take it on.

[martinmcwhorter]

I, like @Ppchiu, would be willing to take this on.

[voronianski]

Limitations of $cookieStore forced me to port common and well-known jquery-cookie plugin as separate Angular cookie provider, check it here - https://github.com/voronianski/ngKookies

[caitp]

we should look into that and see if it looks suitable for inclusion as a core module (if that sounds alright with you @voronianski)

[voronianski]

@caitp this sounds great!

[zoltantarcsay]

+1

[gelus]

I'd love to take this one if it is available. however it looks like it has already been taken care of by this commit: d456789

Can any one verify this?
@zoltantarcsay, since you've most recently +1ed it, is it still an issue?

[catindev]

+1

[stevermeister]

I've updated my module fix - ng-biscuit, but of course ngKookies looks more mature