Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Double $destroy #8504

Closed
lgalfaso opened this issue Aug 6, 2014 · 2 comments
Closed

Double $destroy #8504

lgalfaso opened this issue Aug 6, 2014 · 2 comments

Comments

@lgalfaso
Copy link
Contributor

lgalfaso commented Aug 6, 2014

Opening as a placeholder to open the discussion

Right now, it is possible for a listener on '$destroy' to get called twice.
http://plnkr.co/edit/uQmoQS01eR9ApWp8tNSo?p=preview
Is this a bug or something directives/listeners have to be able to handle?
@petebacondarwin
Copy link
Contributor

When looking at issues with ngIf and ngRepeat recently @IgorMinar and I discussed this and decided that it should be something that listeners should have to be able to cope with.

@lgalfaso
Copy link
Contributor Author

lgalfaso commented Aug 6, 2014

@petebacondarwin thanks for the info. Closing this

@lgalfaso lgalfaso closed this as completed Aug 6, 2014
@lgalfaso lgalfaso mentioned this issue Sep 18, 2014
Closed
lgalfaso added a commit that referenced this issue Sep 29, 2014
@lgalfaso @petebacondarwin
fix($compile): Resolve leak with asynchronous compilation
6303c3d 
Stop an asynchronous compilation when this is performed on an
already destroyed scope

Closes #9199
Closes #9079
Closes #8504
Closes #9197
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Sep 29, 2014
@petebacondarwin
fix($compile): Resolve leak with asynchronous compilation
3c8c88e 
Stop an asynchronous compilation when this is performed on an
already destroyed scope

Closes angular#9199
Closes angular#9079
Closes angular#8504
Closes angular#9197
@petebacondarwin petebacondarwin mentioned this issue Sep 29, 2014
Closed
petebacondarwin added a commit that referenced this issue Sep 29, 2014
@petebacondarwin
fix($compile): Resolve leak with asynchronous compilation
5c9c197 
Stop an asynchronous compilation when this is performed on an
already destroyed scope

Closes #9199
Closes #9079
Closes #8504
Closes #9197
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petebacondarwin @lgalfaso