limitToFilter() handles Infinity incorrectly

[flashbackzoo]

If the limit argument is Infinity, it's parsed to NaN by int()

limit should remain Infinity

[caitp]

maybe this is a bug, but it seems like a weird thing to use Infinity for, what is the use case? Are you sort of trying to use this to toggle between limiting and not limiting?

[flashbackzoo]

Yeah pretty much. If a user sets itemsPerPage to 0, show all items. So something like:

<li ng-repeat="item in items | limitTo:itemsPerPage"></li>

[caitp]

I think the expected behaviour of limitTo:0 is probably the empty collection/string o_o, unless you're translating it manually

[flashbackzoo]

I'm doing $scope.itemsPerPage = userSetVar === 0 ? Infinity : userSetVar; in my controller. So in my ngRepeat itemsPerPage will be an integer > 0 or Infinity. I get the expected behavior (all items in the collection showing) when I set a breakpoint in limitToFilter and set limit back to Infinity manually.

[caitp]

Alright, well, want to test my PR and see if that logic works for you? I'm not sure when/if it will land, though. It's a pretty simple fix and shouldn't be a breaking change, so we can probably triage it for the next beta, if not this one.

[flashbackzoo]

Cool, I'll take a look later today. Thanks for the quick response :)

[jlsanchezsanz]

I think a better solution for this issue would be using array's length instead of Infinity.

Example: I wanted to show a paginated table with a search input and when input value is different from '', pagination should be disabled so that it can show all filtered items in the same view.

<input type="text" ng-model="searchLink" placeholder="Search">
...
<tr ng-repeat="link in links | orderBy:order:reverse | startFrom: (!searchLink || '') && ((currentPage - 1) * pageSize + 1) | limitTo: (!searchLink && pageSize) || links.length | filter:searchLink">