This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Potential fix for #6162 #6421
Closed
Potential fix for #6162 #6421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
Ping @caitp |
|
Thanks, I'll look over this in a sec |
| var href = elm[0].getAttribute('href'); | ||
|
|
||
| if (href.indexOf('://' == -1)) { // Ignore absolute URLs | ||
| if (href[0] == '/') { |
There was a problem hiding this comment.
Even though old IE is not supported, it's probably better to use charAt() rather than the array index annotation --- and maybe just cache the value so that it doesn't need to be fetched multiple times.
caitp
added a commit
to caitp/angular.js
that referenced
this pull request
Mar 28, 2014
…x them This is temporary
|
@richardcrichardc I have done some extra work on this at #6899 --- It still needs to be cleaned up a bit more, but this is getting there. |
caitp
added a commit
to caitp/angular.js
that referenced
this pull request
Mar 28, 2014
…x them This is temporary
caitp
added a commit
to caitp/angular.js
that referenced
this pull request
Apr 9, 2014
…x them This CL fixes problems and adds test cases for changes from angular#6421. Changes include fixing the algorithm for preprocessing href attribute values, as well as supporting xlink:href attributes.
caitp
added a commit
that referenced
this pull request
Apr 17, 2014
…cy browsers This CL fixes problems and adds test cases for changes from #6421. Changes include fixing the algorithm for preprocessing href attribute values, as well as supporting xlink:href attributes. Credit for the original URL parsing algorithm still goes to @richardcrichardc. Good work, champ!
caitp
pushed a commit
to caitp/angular.js
that referenced
this pull request
Apr 17, 2014
…Mode Previously, LocationHashbangInHtml5Url, which is used when html5Mode is enabled in browsers which do not support the history API (IE8/9), would behave very inconsistently WRT relative URLs always being resolved relative to the app root url. This fix enables these legacy browsers to behave like history enabled browsers, by processing href attributes in order to resolve urls correctly. Closes angular#6162 Closes angular#6421 Closes angular#6899 Closes angular#6832 Closes angular#6834
caitp
added a commit
to caitp/angular.js
that referenced
this pull request
Apr 17, 2014
…cy browsers This CL fixes problems and adds test cases for changes from angular#6421. Changes include fixing the algorithm for preprocessing href attribute values, as well as supporting xlink:href attributes. Credit for the original URL parsing algorithm still goes to @richardcrichardc. Good work, champ!
caitp
pushed a commit
that referenced
this pull request
Apr 18, 2014
…Mode Previously, LocationHashbangInHtml5Url, which is used when html5Mode is enabled in browsers which do not support the history API (IE8/9), would behave very inconsistently WRT relative URLs always being resolved relative to the app root url. This fix enables these legacy browsers to behave like history enabled browsers, by processing href attributes in order to resolve urls correctly. Closes #6162 Closes #6421 Closes #6899 Closes #6832 Closes #6834
caitp
added a commit
that referenced
this pull request
Apr 18, 2014
…cy browsers This CL fixes problems and adds test cases for changes from #6421. Changes include fixing the algorithm for preprocessing href attribute values, as well as supporting xlink:href attributes. Credit for the original URL parsing algorithm still goes to @richardcrichardc. Good work, champ!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6162.
As noted in #6162, this fix is not ready to merge.