Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

$compile throws an error when template has 'tfoot' as root element #6289

Closed
volkert opened this issue Feb 17, 2014 · 2 comments
Closed

$compile throws an error when template has 'tfoot' as root element #6289

volkert opened this issue Feb 17, 2014 · 2 comments

Comments

@volkert
Copy link

volkert commented Feb 17, 2014

The following plnkr shows the problem:

http://plnkr.co/edit/40HpRHCNlQm02znrwV4p

Templates with 'tfoot' as root element throw an error. This was already fixed for other table elements like td, tr and tbody in this commit:
31c450b

I would love to fix this issue and contribute, but unfortunately I'm not sure where to begin. Any recommendations?
@lgalfaso
Copy link
Contributor

I think this should be an easy change, will post a PR in a few

lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Feb 17, 2014
@lgalfaso
fix($compile): support templates with thead and tfoot root elements
7a16546 
If the first element in a template is a <thead> or a <tfoot>, then
using the existing logic to handle table elements compilation.

Closes angular#6289
lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Feb 17, 2014
@lgalfaso
fix($compile): support templates with thead and tfoot root elements
4154064 
If the first element in a template is a <thead> or a <tfoot>, then
use the existing logic to handle table elements compilation.

Closes angular#6289
@lgalfaso lgalfaso mentioned this issue Feb 17, 2014
Closed
@caitp
Copy link
Contributor

caitp commented Feb 17, 2014

Yes, I forgot to add support for THEAD and TFOOT, should be a pretty trivial fix.

lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Feb 17, 2014
@lgalfaso
fix($compile): support templates with thead and tfoot root elements
6a8130a 
If the first element in a template is a <thead> or a <tfoot>, then
use the existing logic to handle table elements compilation.

Closes angular#6289
lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Feb 22, 2014
@lgalfaso
fix($compile): support templates with thead and tfoot root elements
acaf3b9 
If the first element in a template is a <thead> or a <tfoot>, then
use the existing logic to handle table elements compilation.

Closes angular#6289
btford pushed a commit to btford/angular.js that referenced this issue Mar 6, 2014
@lgalfaso @btford
fix($compile): support templates with thead and tfoot root elements
df1c6b1 
If the first element in a template is a <thead> or a <tfoot>, then
use the existing logic to handle table elements compilation.

Closes angular#6289
@btford btford closed this as completed in 53ec5e1 Mar 7, 2014
btford pushed a commit that referenced this issue Mar 7, 2014
@lgalfaso @btford
fix($compile): support templates with thead and tfoot root elements
ca0ac64 
If the first element in a template is a <thead> or a <tfoot>, then
use the existing logic to handle table elements compilation.

Closes #6289
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix($compile): support templates with thead and tfoot root elements lgalfaso/angular.js
4 participants
@volkert @IgorMinar @lgalfaso @caitp