TypeError with ngAnimate

[mayanklahiri]

Hi, I'm using the latest Angular 1.2 head at Google (I'm lahiri@). I occasionally get the following error when I've injected ngAnimate into my app -- without actually using it. The ng-animate directive isn't invoked anywhere, and I don't have any CSS transitions. Removing ngAnimate from my app's module dependencies gets rid of the error.

TypeError: Cannot call method 'querySelectorAll' of undefined
    at cancelChildAnimations (http://localhost:8080/dev/js_deps.js:426:92)
    at Object.leave (http://localhost:8080/dev/js_deps.js:414:227)
    at ngRepeatAction (http://localhost:8080/dev/js_deps.js:345:403)
    at Object.$watchCollectionAction [as fn] (http://localhost:8080/dev/js_deps.js:253:80)
    at Scope.$digest (http://localhost:8080/dev/js_deps.js:254:472)
    at Scope.$apply (http://localhost:8080/dev/js_deps.js:258:425)
    at HTMLAnchorElement.<anonymous> (http://localhost:8080/dev/js_deps.js:333:86)
    at http://localhost:8080/dev/js_deps.js:63:60
    at forEach (http://localhost:8080/dev/js_deps.js:11:71)
    at HTMLAnchorElement.eventHandler (http://localhost:8080/dev/js_deps.js:63:18)

[IgorMinar]

@matsko can you look into this please?

[Francisc]

This happens when an element with ng-repeat has an ng-if directive from what I've seen.

e.g. <div ng-repeat="item in data" ng-if="item.quantity>0"></div>

This is because here, extractElementNode(element) returns undefined when element is an HTML comment node (<!-- ngIf: item.quantity>0 -->), then undefined.querySelectorAll(...) throws the error.

var node = extractElementNode(element);

[Francisc]

I would have extractElementNode() return an empty array rather than check if node is truthy.
Or if you prefer the if(node) check, at least make sure extractElementNode() intentionally returns null instead leaving it to the JS engine to return undefined.

I will make a pull request for that if you prefer my approach. Please let me know.

[d4rkr00t]

Method returns a html node or undefined not array, i can check if node === undefined, but i see no reason.

[Francisc]

You're right, sorry. I confused it with something else. The method returns HTML node elements.
However, I would return null from extractElementNode() to indicate intention. JavaScript usually uses undefined.

[kmlx]

+1

[matsko]

Landed as c914cd9