Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ng-class does not play simple CSS transitions when ngAnimate is included #6019

Closed
dallonf opened this issue Jan 28, 2014 · 4 comments
Closed

Comments

@dallonf
Copy link

dallonf commented Jan 28, 2014

When ngAnimate is listed as an app's dependency, very basic CSS transitions do not animate. Here's a quick, dead-simple repro: http://plnkr.co/gZiIkxw007m0STgTfm6R

Fiddling with the version numbers, it looks like the issue was introduced in v1.2.6.

@matsko
Copy link
Contributor

matsko commented Feb 3, 2014

This is a known issue with $animate and will be refactored and fixed in 1.2.11. The goal is to make $animate respect natural transitions as best as possible.

@matsko matsko self-assigned this Feb 3, 2014
@matsko matsko added this to the 1.2.11 milestone Feb 3, 2014
@tbosch tbosch modified the milestones: 1.2.12, 1.2.11 Feb 3, 2014
@matsko
Copy link
Contributor

matsko commented Feb 3, 2014

Correction. It will be released with 1.2.12 (which is this Friday). I didn't realize that 1.2.11 was released late (today).

@tbosch tbosch modified the milestones: 1.2.13, 1.2.12 Feb 7, 2014
@dallonf
Copy link
Author

dallonf commented Feb 10, 2014

What is the status on this issue? 1.2.12 seems to be released, but the changelog does not mention this issue.

@matsko
Copy link
Contributor

matsko commented Feb 10, 2014

Not fixed yet. Had to change the internals of $animate to allow for this to work. Working hard to get this for 1.2.13.

matsko added a commit to matsko/angular.js that referenced this issue Feb 14, 2014
BREAKING CHANGE

ngClass and {{ class }} will call the setClass animation callback instead
of addClass / removeClass when both a addClass/removeClass operation is
being executed on the element during the animation. Please include
the setClass animation callback as well as addClass and removeClass within
your JS animations to work with ngClass and {{ class }} directives.

Closes angular#6019
matsko added a commit to matsko/angular.js that referenced this issue Feb 14, 2014
BREAKING CHANGE

ngClass and {{ class }} will call the setClass animation callback instead
of addClass / removeClass when both a addClass/removeClass operation is
being executed on the element during the animation. Please include
the setClass animation callback as well as addClass and removeClass within
your JS animations to work with ngClass and {{ class }} directives.

Closes angular#6019
IgorMinar pushed a commit to IgorMinar/angular.js that referenced this issue Feb 14, 2014
BREAKING CHANGE

ngClass and {{ class }} will call the setClass animation callback instead
of addClass / removeClass when both a addClass/removeClass operation is
being executed on the element during the animation. Please include
the setClass animation callback as well as addClass and removeClass within
your JS animations to work with ngClass and {{ class }} directives.

Closes angular#6019
IgorMinar pushed a commit to IgorMinar/angular.js that referenced this issue Feb 14, 2014
BREAKING CHANGE

ngClass and {{ class }} will call the setClass animation callback instead
of addClass / removeClass when both a addClass/removeClass operation is
being executed on the element during the animation. Please include
the setClass animation callback as well as addClass and removeClass within
your JS animations to work with ngClass and {{ class }} directives.

Closes angular#6019
@matsko matsko closed this as completed in 4f84f6b Feb 15, 2014
khepin pushed a commit to khepin/angular.js that referenced this issue Feb 19, 2014
BREAKING CHANGE: ngClass and {{ class }} will now call the `setClass`
animation callback instead of addClass / removeClass when both a
addClass/removeClass operation is being executed on the element during the animation.

Please include the setClass animation callback as well as addClass and removeClass within
your JS animations to work with ngClass and {{ class }} directives.

Closes angular#6019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants