ngResource: '$' in pamater values are not escaped properly #6003

tam4s · 2014-01-27T17:56:19Z

1 liner demonstration in a browser JS console:

angular.injector(['ngResource']).get('$resource')('/search/:str').get({'str': 'hello$'})
GET http://docs.angularjs.org/search/hello$1 404 (Not Found)

Notice the extra '1' in the URL.

…ncoding URI Previously, if a URL parameter value included a $, it would replace the dollar sign with a literal '$1' for mysterious reasons. Using a function rather than a replacement string circumvents this behaviour and produces a more expected result. Closes angular#6003

caitp · 2014-01-27T19:10:22Z

Interesting, I've taken a stab at correcting this, would you care to try my patch and see if it introduces any regressions not caught by the tests?

…ncoding URI Previously, if a URL parameter value included a $, it would replace the dollar sign with a literal '$1' for mysterious reasons. Using a function rather than a replacement string circumvents this behaviour and produces a more expected result. Closes angular#6003

caitp mentioned this issue Jan 27, 2014

fix(ngResource): don't append number to '$' in url param value when encoding URI #6004

Closed

ghost assigned vojtajina Jan 28, 2014

caitp closed this as completed in ce1f1f9 Feb 3, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ngResource: '$' in pamater values are not escaped properly #6003

ngResource: '$' in pamater values are not escaped properly #6003

tam4s commented Jan 27, 2014

caitp commented Jan 27, 2014

ngResource: '$' in pamater values are not escaped properly #6003

ngResource: '$' in pamater values are not escaped properly #6003

Comments

tam4s commented Jan 27, 2014

caitp commented Jan 27, 2014