Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ngClick + ngFocus = $rootScope:inprog error #5945

Closed
eyelidlessness opened this issue Jan 23, 2014 · 0 comments
Closed

ngClick + ngFocus = $rootScope:inprog error #5945

eyelidlessness opened this issue Jan 23, 2014 · 0 comments
Labels
component: misc core component: scopes type: bug
Milestone
Backlog - won't fix

Comments

@eyelidlessness
Copy link

Steps to reproduce:

  1. Set up a directive with:
    • an element with ng-click
    • an input with ng-focus
  2. Inside the ng-click handler, call input.focus()

Expected result:

Input will focus, and ng-focus handler will be called.

Observed result:

Input focuses, but $rootScope:inprog error thrown. Error cannot be caught. ng-focus handler never called.

Example code

http://jsfiddle.net/MVxqj/2/
Closed
@Narretz Narretz mentioned this issue Feb 20, 2014
Closed
Narretz added a commit to Narretz/angular.js that referenced this issue Mar 29, 2014
@Narretz
fix(ngEventDirs): blur and focus use to prevent inprog errors
dcce7a8 
Fixes angular#5945
Narretz added a commit to Narretz/angular.js that referenced this issue Mar 29, 2014
@Narretz
fix(ngEventDirs): blur and focus use $evalAysnc to prevent inprog errors
f6ebcaf 
Fixes angular#5945
Narretz added a commit to Narretz/angular.js that referenced this issue Mar 29, 2014
@Narretz
fix(ngEventDirs): blur and focus use $evalAysnc to prevent inprog errors
a8a6126 
Fixes angular#5945
Closes angular#5402
Narretz added a commit to Narretz/angular.js that referenced this issue Mar 29, 2014
@Narretz
fix(ngEventDirs): blur and focus use $evalAysnc to prevent inprog errors
6f77552 
Fixes angular#5945
Closes angular#5402
Narretz added a commit to Narretz/angular.js that referenced this issue Mar 29, 2014
@Narretz
fix(ngEventDirs): blur and focus use $evalAysnc to prevent inprog errors
8a3d026 
Fixes angular#5945
Closes angular#5402
@Narretz Narretz mentioned this issue Mar 29, 2014
Closed
Narretz added a commit to Narretz/angular.js that referenced this issue Jul 15, 2014
@Narretz
fix(ngEventDirs): check $$phase in handler to prevent inprog errors
1e8a944 
Fixes angular#5945
Closes angular#5402
@Narretz Narretz added this to the Backlog milestone Jul 18, 2014
@btford btford removed the gh: issue label Aug 20, 2014
tbosch added a commit to tbosch/angular.js that referenced this issue Aug 27, 2014
@tbosch
fix(ngEventDirs): execute blur and focus expression using `scope.…
8d6c7ed 
…$evalAsync`

BREAKING CHANGE:
The `blur` and `focus` event fire synchronously, also during DOM operations
that add/remove elements. This lead to errors as the Angular model was not
in a consistent state.

This change executes the expression of those events now asynchronously.

Related to angular#5945
Fixes angular#4979
@tbosch tbosch mentioned this issue Aug 27, 2014
Closed
tbosch added a commit to tbosch/angular.js that referenced this issue Aug 27, 2014
@tbosch
fix(ngEventDirs): execute blur and focus expression using `scope.…
3db5ff1 
…$evalAsync`

BREAKING CHANGE:
The `blur` and `focus` event fire synchronously, also during DOM operations
that add/remove elements. This lead to errors as the Angular model was not
in a consistent state.

This change executes the expression of those events now asynchronously.

Fixes angular#4979
Fixes angular#5945
Closes angular#8803
Closes angular#6910
Closes angular#5402
tbosch added a commit to tbosch/angular.js that referenced this issue Aug 28, 2014
@tbosch
fix(ngEventDirs): execute blur and focus expression using `scope.…
df13570 
…$evalAsync`

BREAKING CHANGE:
The `blur` and `focus` event fire synchronously, also during DOM operations
that remove elements. This lead to errors as the Angular model was not
in a consistent state. See this [fiddle](http://jsfiddle.net/fq1dq5yb/) for a demo.

This change executes the expression of those events using
`scope.$evalAsync` if an `$apply` is in progress, otherwise
keeps the old behavior.

Fixes angular#4979
Fixes angular#5945
Closes angular#8803
Closes angular#6910
Closes angular#5402
tbosch added a commit to tbosch/angular.js that referenced this issue Aug 28, 2014
@tbosch
fix(ngEventDirs): execute blur and focus expression using `scope.…
1c2c4c7 
…$evalAsync`

BREAKING CHANGE:
The `blur` and `focus` event fire synchronously, also during DOM operations
that remove elements. This lead to errors as the Angular model was not
in a consistent state. See this [fiddle](http://jsfiddle.net/fq1dq5yb/) for a demo.

This change executes the expression of those events using
`scope.$evalAsync` if an `$apply` is in progress, otherwise
keeps the old behavior.

Fixes angular#4979
Fixes angular#5945
Closes angular#8803
Closes angular#6910
Closes angular#5402
@tbosch tbosch closed this as completed in 719c747 Aug 28, 2014
tbosch added a commit that referenced this issue Aug 29, 2014
@tbosch
fix(ngEventDirs): execute blur and focus expression using `scope.…
54f0bc0 
…$evalAsync`

BREAKING CHANGE:
The `blur` and `focus` event fire synchronously, also during DOM operations
that remove elements. This lead to errors as the Angular model was not
in a consistent state. See this [fiddle](http://jsfiddle.net/fq1dq5yb/) for a demo.

This change executes the expression of those events using
`scope.$evalAsync` if an `$apply` is in progress, otherwise
keeps the old behavior.

Fixes #4979
Fixes #5945
Closes #8803
Closes #6910
Closes #5402
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: misc core component: scopes type: bug
Projects
None yet
Milestone
Backlog - won't fix
Development

Successfully merging a pull request may close this issue.

fix(ngEventDirs): blur and focus use $evalAsync to prevent inprog errors Narretz/angular.js
3 participants
@eyelidlessness @btford @Narretz