This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(a): don't preventDefault on click when SVGAElement has an xlink:href attribute #5897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,11 +32,14 @@ var htmlAnchorDirective = valueFn({ | |||
| element.append(document.createComment('IE fix')); | |||
| } | |||
|
|
|||
| if (!attr.href && !attr.name) { | |||
| if (!attr.href && !attr.xlinkHref && !attr.name) { | |||
There was a problem hiding this comment.
why exactly do we care about the 'name' attribute? I don't really get that
There was a problem hiding this comment.
if it has name then it's just an anchor e.g. <a name="someId"></a> and in that case we don't need to listen for clicks on this element.
…ref attribute Before this change, an SVGAElement with an xlink:href attribute and no href or name attribute which was compiled by the angular HTML compiler would never be clickable, due to the htmlAnchorDirective calling event.preventDefault() due to the missing href attribute. This change corrects this behaviour by also testing the xlink:href attribute if the element in question is determined to be an SVG anchor tag (with the href property having type SVGAnimatedString) Closes angular#5896
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, an SVGAElement with an xlink:href attribute and no href or name attribute which was compiled by the angular HTML compiler would never be clickable, due to the htmlAnchorDirective calling event.preventDefault() due to the missing href attribute.
This change corrects this behaviour by also testing the xlink:href attribute if the element in question is determined to be an SVG anchor tag (with the href property having type SVGAnimatedString)
Some proper E2E testing would test this fix much more effectively.
This is demonstrated to be working here (edit here, but the link won't work within the iframe, only outside it)
Closes #5896