Svg link don't work even if there is no angular var inside #5896

altair2010 · 2014-01-20T15:28:07Z

See this jsffidle : http://jsfiddle.net/Altair2010/SLSxs/

There is only a angular var ouside the svg => angular bind it with the model value.
and a svg with 2 rect. The second one have an anchor.

The anchor don't work, but if you remove the "ng-app" attribute, it work.

caitp · 2014-01-20T15:58:20Z

the reason for this is because the htmlAnchorDirective checks for the href attribute, and prevents default if it's not there.

To be honest, this is a pretty trivial bug to fix, I'll write up a quick patch. Thanks for reporting this =)

Before this change, SVG elements without an 'href' attribute (but with an xlink:href attribute) within the application would always have their click event preventDefault, due to the href attribute being falsy. This change fixes this by giving an SVGAElement a separate link function which is concerned with the xlink:href attribute. Closes angular#5896

…ref attribute Before this change, an SVGAElement with an xlink:href attribute and no href or name attribute which was compiled by the angular HTML compiler would never be clickable, due to the htmlAnchorDirective calling event.preventDefault() due to the missing href attribute. This change corrects this behaviour by also testing the xlink:href attribute if the element in question is determined to be an SVG anchor tag (with the href property having type SVGAnimatedString) Closes angular#5896

…ref attribute Before this change, an SVGAElement with an xlink:href attribute and no href or name attribute which was compiled by the angular HTML compiler would never be clickable, due to the htmlAnchorDirective calling event.preventDefault() due to the missing href attribute. This change corrects this behaviour by also testing the xlink:href attribute if the element in question is determined to be an SVG anchor tag (with the href property having type SVGAnimatedString) Closes #5896 Closes #5897

caitp mentioned this issue Jan 20, 2014

fix(a): don't preventDefault on click when SVGAElement has an xlink:href attribute #5897

Closed

caitp closed this as completed in ccd4227 Jan 22, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Svg link don't work even if there is no angular var inside #5896

Svg link don't work even if there is no angular var inside #5896

altair2010 commented Jan 20, 2014

caitp commented Jan 20, 2014

Svg link don't work even if there is no angular var inside #5896

Svg link don't work even if there is no angular var inside #5896

Comments

altair2010 commented Jan 20, 2014

caitp commented Jan 20, 2014