Some Animations do not work after upgrading to 1.2.9

[sonoman]

I have an entire application with animated transitions using ng-view, the classic router, and resolve functions to load content to be passed on the next controller.
I updated to 1.2.9, and suddenly, one (and only one) transition stopped working.

All views have the same effect (sliding). except that the failing one has a resolve function that executes a $http get that takes more than what take the other views.

The app transitions normally between the other views, until I navigate to the failing one; at that moment the new view does not animate at all; it just appears taking the whole space, even before the old view ends animating.

Back to 1.2.8 for now....

[SnackyPete]

To add a little more detail to this issue...

This happens to me too, but not always (a caching issue?). However, I've noticed a few more things. I made the screens that slide into view move very slowly and also made them partially transparent so I could see if anything was going on behind them -- sure enough, there was.

When a div representing the screen just suddenly appears (rather than sliding in using css animation), this seems to be a duplicate div that is overlaid onto everything else. Links on it do not respond to user input. A second identical div slides in behind it, and when that animation is fully played, the duplicate overlapping div vanishes and after that everything works as expected.

A second interesting tidbit is that if the user quickly clicks the view-swapping link twice, but not quickly enough to register a double-click, two sliding animations occur. The first one slides in at double speed, the second one (overlaying the first one) slides in at the expected speed. When the slow one completes its animation, everything again returns to normal.

Hope this helps.

[IgorMinar]

@sonoman can you provide more info please? for example listing your css would be great. even better would be if you could reproduce the problem on a mini plunker/jsfiddle app.

[SnackyPete]

Here is a plunker I came up with. It's based on the standard view animation demo that's out there. All I did was make the links and buttons really long so that they were easy to click while the animation was playing. I slowed down the animation speed too, so that the issues are more visible.

I don't know if this is exactly the problem sonoman experienced, but I bet they're linked.

http://plnkr.co/edit/V5dTPMU4ibFl31DJSwpU?p=preview

BTW, this problem occurred back as far as v1.2.4. Perhaps even earlier.

[matsko]

I can definitely see what's going on and it looks like there are two leave animations going on. I should be able to have a fix for 1.2.10.

[SnackyPete]

Please reopen. Issue chieffancypants/angular-loading-bar#37 above was never solved, but attributed to user error. I've updated my plunker to 1.2.10 and the error I reported above persists.

http://plnkr.co/edit/V5dTPMU4ibFl31DJSwpU?p=preview

[caitp]

@SnackyPete this issue is still open, and nobody here has attributed this to user error. angular-loading-bar is a different repository =) I don't think we're going to get any/many animation fixes finished this week, but this issue hasn't been forgotten.

If you care to investigate the issue and see if you can spot the problem and a potential solution, that would be really cool =)

[SnackyPete]

Sorry, I misunderstood the meaning of the 'Closed' icon in schmod's post above.

[matsko]

Hey guys. I have a fix ready, but will go in at the same the time as a much needed refactor for $animate that it will go into with 1.2.11. Please wait until the end of the week.

[SnackyPete]

Hi Matsko. Not wanting to be a pest, but what with the release of 1.2.13, I'm wondering what the priority of this issue now is. Is it being pushed back in favor of other issues, or are you still hopeful that it will come with the next release? Thanks!

[matsko]

Hey @SnackyPete. 1.2.13 was a huge release and it took care of a major CSS-based issue that was lingering for a while and that issue was holding everything else back.

Now that that's out of the way this can be taken care of. And yes it is high priority. We're trying to get the major animation issues done before the focus shifts to 1.3.

Please wait until the end of the week. Sorry for the delays.

[matsko]

Fixed. Finally. Thank you everyone.

[SnackyPete]

Woohoo! Thanks matsko!!