Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Nested property expressions evaluate incorrectly in CSP mode #5591

Closed
dozingcat opened this issue Jan 1, 2014 · 0 comments
Closed

Nested property expressions evaluate incorrectly in CSP mode #5591

dozingcat opened this issue Jan 1, 2014 · 0 comments
Assignees
Milestone

Comments

@dozingcat
Copy link
Contributor

jsfiddle

The property expression of length 3 evaluates correctly when not in CSP mode, as you can see by removing the data-ng-csp attribute in the fiddle. Pull request with fix coming shortly.

@ghost ghost assigned IgorMinar Jan 3, 2014
IgorMinar pushed a commit to IgorMinar/angular.js that referenced this issue Jan 3, 2014
…nted its tests from failing

cspSafeGetterFn incorrectly returned undefined if any of its key parameters were undefined. This
wasn't caught by the $parse unit tests because of a timing problem where $ParseProvider was reading
the CSP flag before the tests manually set it, so the CSP property evaluation tests never ran. Add
test that verifies evaluation of nested properties of multiple lengths.

Closes angular#5591
Closes angular#5592
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
…nted its tests from failing

cspSafeGetterFn incorrectly returned undefined if any of its key parameters were undefined. This
wasn't caught by the $parse unit tests because of a timing problem where $ParseProvider was reading
the CSP flag before the tests manually set it, so the CSP property evaluation tests never ran. Add
test that verifies evaluation of nested properties of multiple lengths.

Closes angular#5591
Closes angular#5592
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
…nted its tests from failing

cspSafeGetterFn incorrectly returned undefined if any of its key parameters were undefined. This
wasn't caught by the $parse unit tests because of a timing problem where $ParseProvider was reading
the CSP flag before the tests manually set it, so the CSP property evaluation tests never ran. Add
test that verifies evaluation of nested properties of multiple lengths.

Closes angular#5591
Closes angular#5592
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants