ngAnimate: 1.2 using ng-class to apply an animation will restart animation secondary class binding updates #4944

corbanbrook · 2013-11-13T22:53:09Z

  <div class="pane" ng-class="{ open: open, 'edit-mode': isEditing }">

a transition is on the open class to handle sliding in and out the pane, but if a secondary class binding updates, in this example the 'edit-mode' class then entire open animation will restart by adding open-add and open-add-active

matsko · 2013-11-15T05:13:35Z

This should fix that: #4958

ngClass works by removing all the former classes and then adding all the new classes to the element during each watch change operation. This may cause transition animations to never render. The ngClass directive will now only add and remove the classes that change during each watch operation. Closes angular#4960 Closes angular#4944

ghost assigned matsko Nov 18, 2013

matsko mentioned this issue Nov 19, 2013

Animate fixes #5015

Closed

matsko closed this as completed in 6b8bbe4 Nov 20, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ngAnimate: 1.2 using ng-class to apply an animation will restart animation secondary class binding updates #4944

ngAnimate: 1.2 using ng-class to apply an animation will restart animation secondary class binding updates #4944

corbanbrook commented Nov 13, 2013

matsko commented Nov 15, 2013

ngAnimate: 1.2 using ng-class to apply an animation will restart animation secondary class binding updates #4944

ngAnimate: 1.2 using ng-class to apply an animation will restart animation secondary class binding updates #4944

Comments

corbanbrook commented Nov 13, 2013

matsko commented Nov 15, 2013