Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Animation scatters ng-views all around the page #4732

Closed
ghost opened this issue Oct 31, 2013 · 7 comments
Closed

Animation scatters ng-views all around the page #4732

ghost opened this issue Oct 31, 2013 · 7 comments

Comments

@ghost
Copy link

ghost commented Oct 31, 2013

http://plnkr.co/edit/s4Q8R80TzRaBdYccgvPr?p=preview

If you click [1] and [2] links by turns, you'll notice that more and more div[ng-view] elements continue to appear on the page.

rc.2 is OK. The regression was introduced by commit 32ad292 - refactor($animate): use CSS3 transition/animation events instead of $timeouts to track ongoing animations

@matsko
Copy link
Contributor

matsko commented Oct 31, 2013

The problem here is that you don't have any styles changing. http://plnkr.co/edit/iPAhbdZhiLU8V8SjIwZI?p=preview

This is an issue since it gives the developer the wrong idea. Working on a separate fix to ensure the animation always closes. RC2 used timeouts and RC3+ uses CSS events.

@ghost
Copy link
Author

ghost commented Oct 31, 2013

The problem here is that you don't have any styles changing.

Yes, that much I've realized, though the issue persists, if you only change ng-enter style and omit ng-leave altogether:
http://plnkr.co/edit/fdYuKRmZqha5LmJACVc2?p=preview

@matsko matsko mentioned this issue Nov 2, 2013
IgorMinar pushed a commit to IgorMinar/angular.js that referenced this issue Nov 6, 2013
matsko added a commit to matsko/angular.js that referenced this issue Nov 6, 2013
@matsko matsko closed this as completed in b89584d Nov 6, 2013
@ghost
Copy link
Author

ghost commented Nov 9, 2013

The issue still presents in v1.2.0. Please reopen.

http://plnkr.co/edit/mHiBWV68zullBwSl0krC?p=preview

If you click links fast enough, animations do not close.

@ghost
Copy link
Author

ghost commented Nov 9, 2013

Another plunkr: http://plnkr.co/edit/s4Q8R80TzRaBdYccgvPr?p=preview

FF24. When ng-leave transition duration is 0.01s, animations are hanging. The same with 0.02s, 0.03s, 0.04s.
0.05s works.

Google Chrome is OK.

@matsko
Copy link
Contributor

matsko commented Nov 19, 2013

Once this PR goes through: #5015 then please try again to see if the issue persists and then I'll reopen if necessary.

@ghost
Copy link
Author

ghost commented Dec 14, 2013

The issue still presents in angular v1.2.5 with FF 25. Google Chrome seems to be ok.

http://jsfiddle.net/aUz53/3/

@matsko
Copy link
Contributor

matsko commented Dec 14, 2013

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant