Circular dependency if exception during resource init

[cyrilchampier]

class MyResource extends $resource("/test", { arg: throw "holy shit!" })

the first time the resource is needed, the exception is throw.
the second time "Error: [$injector:cdep] Circular dependency found: "

It seems that the resource is in cache as an empty object and is considered as INSTANTIATING:
(cache[serviceName] === INSTANTIATING) returns true

[petebacondarwin]

What happens to the first thrown error? Does it swallowed somewhere?

[cyrilchampier]

No, it interrupts the script and log to the console.

[metamatt]

I think that all broken dependencies leave the injector cache in this state, such that all subsequent requests for the same service (circular or not, even completely independent) will receive the "circular dependency found" error.

Here's a jsfiddle that demonstrates the problem

[metamatt]

And here's a patch I propose to fix this (this patch happens to be against 1.2.5)

diff --git a/browser_modules/angular-1.2.5/angular.js b/browser_modules/angular-1.2.5/angular.js
index e2c062b..ddfb27e 100644
--- a/browser_modules/angular-1.2.5/angular.js
+++ b/browser_modules/angular-1.2.5/angular.js
@@ -3644,6 +3644,11 @@ function createInjector(modulesToLoad) {
           path.unshift(serviceName);
           cache[serviceName] = INSTANTIATING;
           return cache[serviceName] = factory(serviceName);
+        } catch (err) {
+          if (cache[serviceName] === INSTANTIATING) {
+            delete cache[serviceName];
+          }
+          throw err;
         } finally {
           path.shift();
         }

Will test more and send a PR.