Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Dirty checking not working on RegExp objects? #2685

Closed
skrivanos opened this issue May 17, 2013 · 0 comments
Closed

Dirty checking not working on RegExp objects? #2685

skrivanos opened this issue May 17, 2013 · 0 comments

Comments

@skrivanos
Copy link

Version: 1.1.4.

This boils down to angular.equals:

> angular.equals(new RegExp('foo'), new RegExp('bar'))
true
This was referenced May 20, 2013
Closed
Closed
IgorMinar pushed a commit that referenced this issue Jul 14, 2013
@bripkens @IgorMinar
fix(angular.equals): add support for regular expressions
a357649 
Regular expression objects didn't used to be considered to be equal when using
'angular.equals'. Dirty checking therefore failed to recognize a
property modification.

Closes #2685

Conflicts:

	test/AngularSpec.js
ctrahey pushed a commit to ctrahey/angular.js that referenced this issue Jul 22, 2013
@bripkens @ctrahey
fix(angular.equals): add support for regular expressions
267e70f 
Regular expression objects didn't used to be considered to be equal when using
'angular.equals'. Dirty checking therefore failed to recognize a
property modification.

Closes angular#2685
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@skrivanos