Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

$cookieStore.get should parse empty string cookies #1918

Closed
gmarketer opened this issue Jan 30, 2013 · 1 comment
Closed

$cookieStore.get should parse empty string cookies #1918

gmarketer opened this issue Jan 30, 2013 · 1 comment

Comments

@gmarketer
Copy link

If server sets cookie 'city_id' to cityId (1,2,3 or 4) or sets empty string if it can't find Id in database then calling $cookieStore.get('city_id') will throw parse exception.
@just-boris
Copy link
Contributor

+1, this would be helpful

alonbardavid added a commit to alonbardavid/angular.js that referenced this issue Apr 20, 2013
@alonbardavid
feat($cookieStore): $cookieStore.get now parses blank string as blank…
8efadf8 
… string

closes angular#1918
@alonbardavid alonbardavid mentioned this issue Apr 22, 2013
Closed
petebacondarwin pushed a commit that referenced this issue May 8, 2013
@alonbardavid @petebacondarwin
feat($cookieStore): $cookieStore.get now parses blank string as blank…
501bfaf 
… string

closes #1918
petebacondarwin pushed a commit that referenced this issue May 8, 2013
@alonbardavid @petebacondarwin
feat($cookieStore): $cookieStore.get now parses blank string as blank…
cf4729f 
… string

closes #1918
petebacondarwin pushed a commit that referenced this issue May 8, 2013
@alonbardavid @petebacondarwin
feat($cookieStore): $cookieStore.get now parses blank string as blank…
1240641 
… string

closes #1918
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@just-boris @gmarketer