Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ngClick broken in AngularJS 1.0.3 with jQuery #1662

Closed
andreev-artem opened this issue Dec 6, 2012 · 3 comments
Closed

ngClick broken in AngularJS 1.0.3 with jQuery #1662

andreev-artem opened this issue Dec 6, 2012 · 3 comments

Comments

@andreev-artem
Copy link

Environment: jQuery, AngularJS 1.0.3

Example: http://jsfiddle.net/andreev_artem/cV3aL/2/
It works without jQuery: http://jsfiddle.net/andreev_artem/cV3aL/1/

This issue caused by commit c81d817.

From jQuery bind documentation:
"Returning false from a handler is equivalent to calling both .preventDefault() and .stopPropagation() on the event object."
@lancon13
Copy link

lancon13 commented Dec 7, 2012

I have similar problem posted which I believe related to this commit as well...
#1651

It doesn't make sense to me preventDefault() and return false are being use together...

@Letsan Letsan mentioned this issue Dec 14, 2012
Closed
@davispw
Copy link

davispw commented Dec 18, 2012

This is caused by c81d817. Quick fix: comment out "return false".

@jtymes jtymes mentioned this issue Dec 19, 2012
Closed
@chicoxyzzy chicoxyzzy mentioned this issue Dec 19, 2012
Closed
IgorMinar added a commit that referenced this issue Jan 8, 2013
@IgorMinar
revert: fix(a): prevent Opera from incorrectly navigating on link click
14948cf 
This reverts commit c81d817.

This commit causes several issues (#1651, #1674, #1662) and doesn't even
contain a test that proves that anything on Opera got actually fixed.

If the original Opera resurfaces, we'll fix it properly.
IgorMinar added a commit that referenced this issue Jan 8, 2013
@IgorMinar
revert: fix(a): prevent Opera from incorrectly navigating on link click
4cda028 
This reverts commit c81d817.

This commit causes several issues (#1651, #1674, #1662) and doesn't even
contain a test that proves that anything on Opera got actually fixed.

If the original Opera resurfaces, we'll fix it properly.
@IgorMinar
Copy link
Contributor

fixed by 14948cf

jamessharp pushed a commit to jamessharp/angular.js that referenced this issue Jan 18, 2013
@IgorMinar @jamessharp
revert: fix(a): prevent Opera from incorrectly navigating on link click
99f5179 
This reverts commit c81d817.

This commit causes several issues (angular#1651, angular#1674, angular#1662) and doesn't even
contain a test that proves that anything on Opera got actually fixed.

If the original Opera resurfaces, we'll fix it properly.
@chicoxyzzy chicoxyzzy mentioned this issue Jan 25, 2013
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@IgorMinar @andreev-artem @davispw @lancon13