$cookies and $cookieStore needs documentation and example #1320
Comments
|
What about this? http://docs.angularjs.org/api/ngCookies.$cookieStore |
|
I see what you mean though, there are no usage examples... |
|
I can't say there's any use to it until there is one. +1 for Usage and examples. |
|
Agree with @symblify and @gotoAndBliss. +1 for Usage/Examples. |
|
I completely agree. |
|
+1 |
|
Is it right that $cookies is an abstraction of $cookieStore ? (like $resource is for $http) I have 2 Examples
|
|
@ThomasDeutsch $cookies can not store objects as a value so if you need to add/read an object to/from cookie you must convert it to/from JSON string. That's what $cookieStore.put() and $cookieStore.get() methods for. $cookies itself adds and deletes cookies on $digest |
$cookieStore service had no way to set cookie attributes (such as expires).
The api for $cookieStore.put and $cookieStore.remove now has a third argument-
options,which allows setting cookie attributes, or deleting cookies under a
specific path.
- to change the path and/or expiration date of a cookie, you can pass an
options object as the third argument to cookies(name,value).
the options object can override Path and Expires when adding a value.
You can pass either path, expires,none or both.
- the path option is checked to be a string and be partial to window.location
otherwise, the default path is used. (warning is logged)
- the expires option is checked to be a Date and in the future,
otherwise no expiration is set. (warning is logged)
- you can now delete a cookie on a specific path by calling
cookie(name,undefined,{path:x})
The $cookie service remains unchanged since supporting cookie attributes
would mean serious backward comptability issues.
Foundations were put in place to make supporting $cookie easier.
GENERIC TEST CHANGE:
To support checking cookie path, all unit-tests now run on path "/karma/tests"
Documentation was updated for both $cookie and $cookieStore with examples.
closes angular#1786, angular#1320
BREAKING CHANGE: As part of the change, deleting a cookie now deletes
cookies set in multiple paths (and duplicate cookies if exists).
Previously only cookies set in the / path were deleted.
Since it is not intutive, if this change breaks someones code, it is
probably as an accidental side-effect.
It is reasonable to assume that most people actually wanted to delete the
cookie even if it wasn't set in the same path (since they can see it).
So while this is a breaking change, it fixes bad behaviour.
If needed, you can delete the cookie in a specific path using $cookieStore.
|
As part of our effort to clean out old issues, this issue is being automatically closed since it has been inactivite for over two months. Please try the newest versions of Angular ( Thanks! |
|
lazy close! |
|
@joseym would you like to submit a PR adding docs for this feature? |
|
Sure Sent from my iPhone On Sep 5, 2013, at 12:54 PM, Brian Ford [email protected] wrote:
|
|
+1 for example and usage |
1 similar comment
|
+1 for example and usage |
|
We will definitely merge a PR that contains runnable examples. In the meantime there are indeed basic usage examples at https://docs.angularjs.org/api/ngCookies/service/$cookies#example |
|
+1 for example and usage |
|
You can check out my repo here for a working example if that helps at all... |
I can't find any official example whatsoever on cookie storage. $cookies also lacks API documentation.
The text was updated successfully, but these errors were encountered: