Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

TranscludingComponentFactory Passes a Wrong Element to onShadowRoot #1435

Closed
vsavkin opened this issue Sep 8, 2014 · 0 comments
Closed

TranscludingComponentFactory Passes a Wrong Element to onShadowRoot #1435

vsavkin opened this issue Sep 8, 2014 · 0 comments

Comments

@vsavkin
Copy link
Contributor

vsavkin commented Sep 8, 2014

TranscludingComponentFactory passes the component's element to onShadowRoot, whereas it should pass an instance of EmulatedShadowRoot.

This means the following will throw:

@Component(useShadowDom: false)
class MyComponent implements ShadowRootAware {
  void onShadowRoot(ShadowRoot shadowRoot) {}
}

Whereas the following will not:

@Component(useShadowDom: false)
class MyComponent implements ShadowRootAware {
  void onShadowRoot(shadowRoot) {} //here shadowRoot is not really a shadow root!!!
}
@vsavkin vsavkin changed the title TranscludingComponentFactory Passes a Wrong Element to ShadowRootAware TranscludingComponentFactory Passes a Wrong Element to onShadowRoot Sep 8, 2014
vsavkin added a commit to vsavkin/angular.dart that referenced this issue Sep 8, 2014
vsavkin added a commit to vsavkin/angular.dart that referenced this issue Sep 8, 2014
vsavkin added a commit to vsavkin/angular.dart that referenced this issue Sep 14, 2014
vsavkin added a commit that referenced this issue Sep 14, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
1 participant