Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for non Administrator CLI user #905

Closed
wants to merge 3 commits into from

Conversation

degiorgig
Copy link
Contributor

In case of non-admin user instead of symlinkSync will just writeFileSync.

In case of non-admin user instead of symlinkSync will just writeFileSync.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@degiorgig
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@degiorgig
Copy link
Contributor Author

Fixes: ng serve => Error: EPERM: operation not permitted, symlink #641

@reflexdemon reflexdemon mentioned this pull request May 27, 2016
@reflexdemon
Copy link
Contributor

When will this be merged?

@degiorgig degiorgig closed this May 27, 2016
@degiorgig degiorgig reopened this May 27, 2016
@filipesilva
Copy link
Contributor

@leader80 thanks so much! I'm looking at this PR right now, and should have it merged soon.

try {
fs.symlinkSync(absoluteFilePath, outputFilePath);
} catch (e) {
const conentStr = fs.readFileSync(absoluteFilePath);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be contentStr?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, will fix it in another PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #981

@filipesilva
Copy link
Contributor

These changes should be in the upcoming beta.6.

devCrossNet pushed a commit to devCrossNet/universal-cli that referenced this pull request Jun 9, 2016
In case of non-admin user instead of symlinkSync will just writeFileSync.

Close angular#905
Fix angular#886
Fix angular#370
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants