-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for non Administrator CLI user #905
Conversation
In case of non-admin user instead of symlinkSync will just writeFileSync.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Fixes: ng serve => Error: EPERM: operation not permitted, symlink #641 |
When will this be merged? |
@leader80 thanks so much! I'm looking at this PR right now, and should have it merged soon. |
try { | ||
fs.symlinkSync(absoluteFilePath, outputFilePath); | ||
} catch (e) { | ||
const conentStr = fs.readFileSync(absoluteFilePath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be contentStr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, will fix it in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #981
These changes should be in the upcoming |
In case of non-admin user instead of symlinkSync will just writeFileSync. Close angular#905 Fix angular#886 Fix angular#370
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In case of non-admin user instead of symlinkSync will just writeFileSync.